[PATCH 5/6] Re: Remove mix of high and low-precedence booleans
From: Nicolas Sebrecht <hidden>
Date: 2016-06-15 22:46:41
On Wed, Apr 29, 2009 at 09:12:22AM -0400, Bill Pemberton wrote:
Booleans such as &&, ||, ! have higher precedence than and, or, not. They should not be mixed.
But round brackets have higher precedence than both '&&' and 'and', right? If so, why thoses changes?
- } elsif (-d $f and !check_file_rev_conflict($f)) {
+ } elsif (-d $f && !check_file_rev_conflict($f)) {- } elsif ((-f $f or -p $f) and !check_file_rev_conflict($f)) {
+ } elsif ((-f $f || -p $f) && !check_file_rev_conflict($f)) {- if (!defined $valid_re or $resp =~ /$valid_re/) {
+ if (!defined $valid_re || $resp =~ /$valid_re/) {-- Nicolas Sebrecht