Re: [PATCH v2] Add an option not to use link(src, dest) && unlink(src) when that is unreliable

On Samstag, 25. April 2009, Junio C Hamano wrote:

Johannes Schindelin [off-list ref] writes:

quoted

It seems that accessing NTFS partitions with ufsd (at least on my EeePC)
has an unnerving bug: if you link() a file and unlink() it right away,
the target of the link() will have the correct size, but consist of NULs.

It seems as if the calls are simply not serialized correctly, as
single-stepping through the function move_temp_to_file() works
flawlessly.

As ufsd is "Commertial software" (sic!), I cannot fix it, and have to
work around it in Git.

At the same time, it seems that this fixes msysGit issues 222 and 229 to
assume that Windows cannot handle link() && unlink().

Signed-off-by: Johannes Schindelin <redacted>
Acked-by: Johannes Sixt <redacted>

Hannes, are you ok with this?

Yes. We have been using rename() instead of link() on Windows until recently 
anyway (until link() was implemented, 7be401e06, 2009-01-24). There is no 
regression to be expected from this side.

-- Hannes