[PATCH RFC3.5.1 03/12] send-email: Interpret --smtp-server "" as "use a default".
From: Michael Witten <hidden>
Date: 2016-06-15 22:46:37
Subsystem:
documentation, the rest · Maintainers:
Jonathan Corbet, Linus Torvalds
Why not? It's at least useful for testing. Signed-off-by: Michael Witten <redacted> --- NOTE: This also resulted in a similar change to: [PATCH RFC3.5 04/12] send-email: Verification... Documentation/git-send-email.txt | 4 +++- git-send-email.perl | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index 071e9bf..0937dd0 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt@@ -132,7 +132,9 @@ user is prompted for a password while the input is masked for privacy. be specified by the 'sendemail.smtpserver' configuration variable; the built-in default is `/usr/sbin/sendmail` or `/usr/lib/sendmail` if such a program is available, or - `localhost` otherwise. + `localhost` otherwise. Also, the built-in default is used if + `<host>` or 'sendemail.smtpserver' is the empty string (for + example, if '--smtp-server ""' is specified on the command line). --smtp-server-port=<port>:: Specifies a port different from the default port (SMTP
diff --git a/git-send-email.perl b/git-send-email.perl
index fed3554..be6d171 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl@@ -675,7 +675,7 @@ if (defined $initial_reply_to) { $initial_reply_to = "<$initial_reply_to>" if $initial_reply_to ne ''; } -if (defined $smtp_server) { +if (defined $smtp_server && $smtp_server ne '') { $smtp_server_is_a_command = ($smtp_server =~ m{^/});
--
1.6.2.2.479.g2aec