Re: [JGIT PATCH 3/3] Extracted AWT-independent superclass from DefaultSshSessionFactory
From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:46:37
Constantine Plotnikov [off-list ref] wrote:
The part of DefaultSshSessionFactory that does not depend on AWT was refactored to the super class SshConfigSessionFactory. The parts of DefaultSshSessionFactory that were used only by the OpenSshConfig class were moved to that class. Signed-off-by: Constantine Plotnikov <redacted>
Thanks. I applied this, but with a couple of style nitpicks corrected.
quoted hunk ↗ jump to hunk
--- a/org.spearce.jgit/src/org/spearce/jgit/transport/OpenSshConfig.java +++ b/org.spearce.jgit/src/org/spearce/jgit/transport/OpenSshConfig.java@@ -95,6 +97,9 @@ public static OpenSshConfig get() { /** Cached entries read out of the configuration file. */ private Map<String, Host> hosts; + /** IANA assigned port number for SSH. */ + static final int SSH_PORT = 22; +
Static constants should be at the top of the class, not after the instance members. -- Shawn.