Thread (5 messages) flat view 5 messages, 3 authors, 2016-06-15

Re: [RFC PATCH] git add -p: new "quit" command at the prompt.

From: Jeff King <hidden>
Date: 2016-06-15 22:46:36

Possibly related (same subject, not in this thread)

On Wed, Apr 15, 2009 at 04:25:55PM -0700, Junio C Hamano wrote:
Currently parse_diff_header() returns the mode line into $mode and the
main loop treats $mode differently from @hunk, which is an array of hunks
parsed by parse_diff().  Treating $mode as a "fake hunk" by unshifting it
at the beginning of @hunk array and teaching the main loop minor details
such as $mode "fake hunk" cannot be edited nor split, I suspect we _could_
unify the two.

ca72468 (add--interactive: allow user to choose mode update, 2008-03-27)
introduced this duplication.  Jeff, what do you think?  I am not sure if
it is worth it.
Yeah, at least at one point I thought that was possible:

  http://article.gmane.org/gmane.comp.version-control.git/78340

Let me see how painful it would be.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help