Thread (21 messages) flat view 21 messages, 3 authors, 2016-06-15

Re: [PATCH 3/8] archive: add a failure test wrt .gitattributes misreading

From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:46:36

2009/4/13 René Scharfe [off-list ref]:
Also, the last sentence of the description may be taken to imply a
mixing of attributes from work tree and exported tree is done, which is
not the case with the patch from series 2 (and shouldn't be).  Perhaps:
"With this option, .gitattributes files are read from the work tree
instead of from the exported tree."
I'm at work and haven't had chance to read other mails carefully. Wrt
to the description, it reads from index too if it fails to read from
worktree. So perhaps "With this option, .gitattributes files are read
from work tree (or from index if they are missing from work tree)
instead of from exported tree.", unless you want to introduce another
"attr direction" to read from work tree only.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help