Re: [PATCH RFC3 08/13] send-email: Remove superfluous `my $editor = ...'

On 2009.04.13 16:39:52 -0700, Stephen Boyd wrote:

Michael Witten wrote:

quoted

-	my $editor = $ENV{GIT_EDITOR} || Git::config(@repo, "core.editor") || $ENV{VISUAL} || $ENV{EDITOR} || "vi";

I don't want to start an editor war, but why is 'vi' here? It seems
that one of the previous four should be set at all times, correct?

Probably because that's how the rest of git works, too. See core.editor
in git-config(1) or launch_editor() in editor.c if you don't trust the
docs.

Oh, and I seem to rely on that behaviour :-)

Björn