Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] graph API: Added logic for colored edges

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:35

Possibly related (same subject, not in this thread)

Allan Caffee [off-list ref] writes:
The problem with making it an index into the column_colors array is that
we don't have a convenient place to test whether the user actually wants
color.  We can't do it in strbuf_write_column because AFAIK there's no
way to get the rev-info to test the options.  I suppose we could define
GIT_NOT_A_COLOR to -1 and just set the color to that when we don't
intend to use color.  (Either way I should probably change that to an
unsigned short.)  What do you think?
Sounds sensible.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help