Re: [PATCH] Fix buffer overflow in config parser

Markus Heidelberg, 09.04.2009:

Thomas Jarosch, 09.04.2009:

quoted

Hello together,

attached is a small patch to fix a buffer overflow in config.c.
Patch is against git master's HEAD.

I didn't send this one inline as I wanted to
preserve the 1024+ byte long line.

You could send the patch inline and attach the example config.

quoted

diff --git a/config.c b/config.c
index b76fe4c..a9c67e8 100644
--- a/config.c
+++ b/config.c

@@ -72,7 +72,7 @@ static char *parse_value(void)
                        }
                }
                if (space) {
-                       if (len)
+                       if (len && len < sizeof(value)-1)
                                value[len++] = ' ';
                        space = 0;

Eh, or maybe better add a "continue;" here, so that only one char per
loop is read.

quoted

                }