Thread (4 messages) 4 messages, 3 authors, 2016-06-15

Re: [PATCH v2] git-pull.sh: better warning message for "git pull" on detached head.

flat view

From: Finn Arne Gangstad <hidden>
Date: 2016-06-15 22:46:34

On Tue, Apr 07, 2009 at 11:56:21AM +0200, Matthieu Moy wrote:
Otherwise, git complains about not finding a branch to pull from in
'branch..merge', which is hardly understandable. While we're there,
reword the sentences slightly.
[...]
+	if [ -z "$curr_branch" ]; then
+		echo "You asked me to pull without telling me which branch you want"
+		echo "to merge with, and you are on a detached HEAD, so I cannot"
[...]
In this case why can't we just do

echo "You are currently not on any branch."

or

echo "git pull cannot be run without arguments unless you are on a branch."

And possibly also something like this:

echo "Usage: git pull <repository> <refspec>."
echo " See git-pull(1) for details."
echo

If you need all the verbosity this error otherwise gives, "detached
HEAD" is probably going to be confusing?

- Finn Arne
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help