Re: [PATCH 1/4] sha1-lookup: add new "sha1_pos" function to efficiently lookup sha1

Heya,

On Sun, Apr 5, 2009 at 21:59, Jeff King [off-list ref] wrote:

 die("BUG: assertion failed in binary search")

Given that we now only have one binary search (which should be re-used
everywhere), I think it's fair enough to describe it like that.

However, if this "oops" has been there for 2 years and nobody has seen
it, it's entirely possible that somebody actually got the binary search
code right in the first place. ;)

Hehe, never underestimate the difficulty of writing a proper binary
search! :P But I do agree two years of 'testing' is more than more
binary searches get before being 'released' ;).

-- 
Cheers,

Sverre Rabbelier