Re: [PATCH] mailmap: resurrect lower-casing of email addresses
From: A Large Angry SCM <hidden>
Date: 2016-06-15 22:46:32
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] mailmap: resurrect lower-casing of email addresses · A Large Angry SCM <hidden>
- 2016-06-15 · Re: [PATCH] mailmap: resurrect lower-casing of email addresses · Johannes Schindelin <hidden>
- 2016-06-15 · Re: [PATCH] mailmap: resurrect lower-casing of email addresses · Markus Heidelberg <hidden>
- 2016-06-15 · Re: [PATCH] mailmap: resurrect lower-casing of email addresses · A Large Angry SCM <hidden>
- 2016-06-15 · Re: [PATCH] mailmap: resurrect lower-casing of email addresses · A Large Angry SCM <hidden>
{I may be late to this change since I'm trying to catch up on the ML.]
Johannes Schindelin wrote:Commit 0925ce4(Add map_user() and clear_mailmap() to mailmap) broke the lower-casing of email addresses. This mostly did not matter if your .mailmap has only lower-case email addresses; However, we did not require .mailmap to contain lowercase-only email addresses.
What part of the email address is this going to lowercase? Only the domain name is case agnostic.
quoted hunk ↗ jump to hunk
Signed-off-by: Johannes Schindelin <redacted> --- lezzee how that goes mailmap.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)diff --git a/mailmap.c b/mailmap.c index f12bb45..6be91b6 100644 --- a/mailmap.c +++ b/mailmap.c@@ -50,6 +50,15 @@ static void add_mapping(struct string_list *map, { struct mailmap_entry *me; int index; + char *p; + + if (old_email) + for (p = old_email; *p; p++) + *p = tolower(*p); + if (new_email) + for (p = new_email; *p; p++) + *p = tolower(*p); + if (old_email == NULL) { old_email = new_email; new_email = NULL;