Re: [PATCH] Allow curl to rewind the read buffers
From: Martin Storsjö <hidden>
Date: 2016-06-15 22:46:32
On Wed, 1 Apr 2009, Junio C Hamano wrote:
It may be obvious to people proficient in cURL, but I had to guess that you perhaps meant to say "when using multi-pass authentication methods, cURL library may need to rewind the read buffers (depending on what is fed by the server), and in order to allow the library to do so, we need to tell it how by providing the way to manipulate the buffers we supply with these IOCTL callbacks." Do I understand you correctly?
Yeah, that's exactly correct.
My point is that the your two-line statement of fact (with a bit more explanation of the fact that follows) was clear but it was unclear to me how that fact translates to the need of what the patch does. We would want the commit log message to be helpful to people who look at the code 6 months down the line and wonder why these lines were added.
The original commit comment was a bit vague in retrospect, yes. I'll reply with an updated version soon. Thanks! // Martin