Re: [PATCH 2/2] send-email: add tests for refactored prompting

2009/3/31 Björn Steinbrink [off-list ref]:

These two cause interactive prompts for me.

Ah, it's because of going through test_must_fail. Grrr, a test farm
for git would be nice. :-)

This should fix it up:

diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index b4de98c..cd34525 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh

@@ -476,7 +476,8 @@ test_expect_success 'confirm detects EOF (inform

assumes y)' '
 test_expect_success 'confirm detects EOF (auto causes failure)' '
        CONFIRM=$(git config --get sendemail.confirm) &&
        git config sendemail.confirm auto &&
-       GIT_SEND_EMAIL_NOTTY=1 \
+       GIT_SEND_EMAIL_NOTTY=1 &&
+       export GIT_SEND_EMAIL_NOTTY &&
                test_must_fail git send-email \
                        --from="Example [off-list ref]" \
                        --to=nobody@example.com \

@@ -490,8 +491,9 @@ test_expect_success 'confirm detects EOF (auto

causes failure)' '
 test_expect_success 'confirm doesnt loop forever' '
        CONFIRM=$(git config --get sendemail.confirm) &&
        git config sendemail.confirm auto &&
-       yes "bogus" | GIT_SEND_EMAIL_NOTTY=1 \
-               test_must_fail git send-email \
+       GIT_SEND_EMAIL_NOTTY=1 &&
+       export GIT_SEND_EMAIL_NOTTY &&
+               yes "bogus" | test_must_fail git send-email \
                        --from="Example [off-list ref]" \
                        --to=nobody@example.com \
                        --smtp-server="$(pwd)/fake.sendmail" \

What's your OS and test shell btw?

j.