Thread (5 messages) flat view 5 messages, 1 author, 2016-06-15
DORMANTno replies

[PATCH 2/4] Header Includes Cleanup Part 2

From: Nathaniel P Dawson <hidden>
Date: 2016-06-15 22:46:31
Subsystem: the rest · Maintainer: Linus Torvalds

Deleted includes of revision.h where log-tree.h was included since
log-tree.h includes it.

Signed-off-by: Nathaniel P Dawson <redacted>
---
 builtin-commit.c      |    3 +--
 builtin-diff.c        |    1 -
 builtin-fast-export.c |    1 -
 builtin-log.c         |    1 -
 builtin-merge.c       |    3 +--
 builtin-rev-list.c    |    3 +--
 diff-no-index.c       |    1 -
 pretty.c              |    3 +--
 revision.c            |    3 +--
 9 files changed, 5 insertions(+), 14 deletions(-)
diff --git a/builtin-commit.c b/builtin-commit.c
index aba5660..0e21313 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -11,11 +11,10 @@
 #include "dir.h"
 #include "diff.h"
 #include "diffcore.h"
-#include "revision.h"
+#include "log-tree.h"
 #include "wt-status.h"
 #include "run-command.h"
 #include "refs.h"
-#include "log-tree.h"
 #include "utf8.h"
 #include "parse-options.h"
 #include "string-list.h"
diff --git a/builtin-diff.c b/builtin-diff.c
index 252c519..50239a9 100644
--- a/builtin-diff.c
+++ b/builtin-diff.c
@@ -9,7 +9,6 @@
 #include "tag.h"
 #include "diff.h"
 #include "diffcore.h"
-#include "revision.h"
 #include "log-tree.h"
 
 struct blobinfo {
diff --git a/builtin-fast-export.c b/builtin-fast-export.c
index b62e48d..e1aa036 100644
--- a/builtin-fast-export.c
+++ b/builtin-fast-export.c
@@ -9,7 +9,6 @@
 #include "diff.h"
 #include "diffcore.h"
 #include "log-tree.h"
-#include "revision.h"
 #include "decorate.h"
 #include "string-list.h"
 #include "utf8.h"
diff --git a/builtin-log.c b/builtin-log.c
index 5105c91..db7c344 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -7,7 +7,6 @@
 #include "builtin.h"
 #include "color.h"
 #include "diff.h"
-#include "revision.h"
 #include "log-tree.h"
 #include "tag.h"
 #include "reflog-walk.h"
diff --git a/builtin-merge.c b/builtin-merge.c
index cb4c645..fb6e61a 100644
--- a/builtin-merge.c
+++ b/builtin-merge.c
@@ -12,12 +12,11 @@
 #include "diff.h"
 #include "refs.h"
 #include "diffcore.h"
-#include "revision.h"
+#include "log-tree.h"
 #include "unpack-trees.h"
 #include "cache-tree.h"
 #include "dir.h"
 #include "utf8.h"
-#include "log-tree.h"
 #include "color.h"
 #include "rerere.h"
 #include "help.h"
diff --git a/builtin-rev-list.c b/builtin-rev-list.c
index cedfe9a..faac425 100644
--- a/builtin-rev-list.c
+++ b/builtin-rev-list.c
@@ -4,9 +4,8 @@
 #include "tag.h"
 #include "tree.h"
 #include "diff.h"
-#include "revision.h"
-#include "list-objects.h"
 #include "log-tree.h"
+#include "list-objects.h"
 #include "graph.h"
 
 /* bits #0-15 in revision.h */
diff --git a/diff-no-index.c b/diff-no-index.c
index cb68b8d..fa8b669 100644
--- a/diff-no-index.c
+++ b/diff-no-index.c
@@ -10,7 +10,6 @@
 #include "tag.h"
 #include "diff.h"
 #include "diffcore.h"
-#include "revision.h"
 #include "log-tree.h"
 #include "string-list.h"
 
diff --git a/pretty.c b/pretty.c
index efa7024..0465de1 100644
--- a/pretty.c
+++ b/pretty.c
@@ -2,10 +2,9 @@
 #include "commit.h"
 #include "utf8.h"
 #include "diff.h"
-#include "revision.h"
+#include "log-tree.h"
 #include "string-list.h"
 #include "mailmap.h"
-#include "log-tree.h"
 #include "color.h"
 
 static char *user_format;
diff --git a/revision.c b/revision.c
index 827108d..18425d6 100644
--- a/revision.c
+++ b/revision.c
@@ -4,12 +4,11 @@
 #include "commit.h"
 #include "diff.h"
 #include "refs.h"
-#include "revision.h"
+#include "log-tree.h"
 #include "graph.h"
 #include "grep.h"
 #include "reflog-walk.h"
 #include "patch-ids.h"
-#include "log-tree.h"
 
 volatile show_early_output_fn_t show_early_output;
 
-- 
1.6.1.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help