Re: [PATCH 1/2] graph.c: avoid compile warnings
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:31
Johannes Schindelin [off-list ref] writes:
quoted hunk
Signed-off-by: Johannes Schindelin <redacted> --- I'd actually like to see this and the next patch squashed in. graph.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)diff --git a/graph.c b/graph.c index 2929c8b..5e2f224 100644 --- a/graph.c +++ b/graph.c@@ -701,8 +701,8 @@ static void graph_output_pre_commit_line(struct git_graph *graph, for (i = 0; i < graph->num_columns; i++) { struct column *col = &graph->columns[i]; if (col->commit == graph->commit) { - seen_this = 1; struct strbuf tmp = STRBUF_INIT; + seen_this = 1;
Which codebase are you working on top of?
quoted hunk
strbuf_addf(&tmp, "| %*s", graph->expansion_row, ""); strbuf_write_column(sb, col, tmp.buf); strbuf_release(&tmp);@@ -921,8 +921,6 @@ static void graph_output_collapsing_line(struct git_graph *graph, struct strbuf { int i; int *tmp_mapping; - static int collapsing_columns[255]; - int collapsing_seen_so_far = 0; /* * Clear out the new_mapping array-- 1.6.2.1.493.g67cf3