Thread (4 messages) flat view 4 messages, 3 authors, 2016-06-15

Re: [PATCH] disable post-checkout test on Cygwin

From: Johannes Sixt <hidden>
Date: 2016-06-15 22:46:24

Junio C Hamano schrieb:
Alex Riesen [off-list ref] writes:
quoted
It is broken because of the tricks we have to play with
lstat to get the bearable perfomance out of the call.
Sadly, it disables access to Cygwin's executable attribute,
which Windows filesystems do not have at all.
Hmm, perhaps when checking hooks to see if they are executable, Cygwin
port should avoid using the "tricks"?  Compared to paths inside the
worktree the number of hooks is a lot smaller, no?
Hmm. Nowadays, we run hooks through run_hook() in run_command.c. It uses
access(..., X_OK), not lstat(). We don't play games with access(), do we?

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help