Re: [PATCH] config: --replace-all with one argument exits properly with a better message.

On Sun, Mar 15, 2009 at 3:53 AM, Junio C Hamano [off-list ref] wrote:

Felipe Contreras [off-list ref] writes:

quoted

On Sat, Mar 14, 2009 at 10:53 PM, Junio C Hamano [off-list ref] wrote:

quoted

Carlos Rica [off-list ref] writes:

quoted

'config --replace-all ONE_ARG' was being treated as 'config NAME VALUE',
showing the error "key does not contain a section: --replace-all".

Hmm, I am getting "error: wrong number of arguments" followed by the long
and somewhat annoying "usage" from the parseopt table dump.

If you find it annoying why don't you remove the usage?

Because the primary target audience of the help text is not me?

Ok. I don't think it makes a big difference to leave it on or off.
People not familiar with 'git config' might find it handy, but I admit
that I also find it a bit annoying, mainly because the error message
gets lost in the noise.

quoted

quoted

Can you work with Felipe to see if this is still needed, or needs to be
fixed in a different way?  It could be that your tests may already pass
over there on 'next'.  I didn't check.

The new code is already checking correctly that --replace-all needs at
least two arguments. However, the "usage" is incorrect and of course
the test will come in handy.

So perhaps you can pick a part of it and send in an update to your
parseoptification series?  I think the series is ready for 'master'
sometime next week if not sooner.

Or maybe Carlos can beat me to do it since it seems he is interested.
Otherwise yeah, I'll do it.

-- 
Felipe Contreras