Re: [PATCH] git-push.txt: describe how to default to pushing only current branch

On 2009 Mar 14, at 15:56, Jeff King wrote:

On Sat, Mar 14, 2009 at 04:34:34PM -0400, Jeff King wrote:

quoted

The question is how it _should_ be rendered. Monospace isn't really
useful for terminals. Maybe simply putting quotation marks around it
would cover all situations (I'm worried it will look funny for
single-word instances).

And here's a patch that does that; skimming through the output it
doesn't look too bad. What do you guys think?

---

The presentation seems OK to me. I thought of two issues:

1) literals that contain a double quote

	$ git grep '`[^`]*"[^`]`' | cat
	config.txt:You can have `[section]` if you have `[section "subsection"]`, but you

   There might be a better regexp to find these, I did not think
   about it too long. The above "hit" seems like a reasonable
   literal string. Maybe it is OK to live with this one
   ("[section "subsection"]").

2) manpage-1.72.xsl 

   I have been setting DOCBOOK_XSL_172 to avoid the ".ft" problem
   (<http://article.gmane.org/gmane.comp.version-control.git/112943>;
   my system is Mac OS X 10.4.11 with MacPorts asciidoc 8.3.1,
   xmlto version 0.0.21, and docbook-xsl 1.74.0). Since non-null
   DOCBOOK_XSL_172 replaces callouts.xsl with manpage-1.72.xsl, I
   added the line to manpage-1.72.xsl.

   Here is the patch if it is deemed appropriate (same line Peff
   added to callouts.xsl):

-- >8 -- 
Subject: [PATCH] manpage-1.72.xsl: wrap inline literal text with double quotes

Signed-off-by: Chris Johnsen <redacted>
---
 Documentation/manpage-1.72.xsl |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/Documentation/manpage-1.72.xsl b/Documentation/manpage-1.72.xsl
index 4065a3a..a39fd55 100644
--- a/Documentation/manpage-1.72.xsl
+++ b/Documentation/manpage-1.72.xsl

@@ -18,4 +18,6 @@
 	<xsl:text>&#x2302;br&#10;</xsl:text>
 </xsl:template>
 
+<xsl:template match="literal">"<xsl:apply-templates/>"</xsl:template>
+
 </xsl:stylesheet>

-- 
1.6.2