Re: [PATCH 2/2] ls-files: fix broken --no-empty-directory
From: Miklos Vajna <hidden>
Date: 2016-06-15 22:46:21
On Sat, Mar 07, 2009 at 08:27:22PM -0500, Jeff King [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/builtin-ls-files.c b/builtin-ls-files.c index 1742c0f..437c366 100644 --- a/builtin-ls-files.c +++ b/builtin-ls-files.c@@ -454,8 +454,8 @@ int cmd_ls_files(int argc, const char **argv, const char *prefix) OPT_BIT(0, "directory", &dir.flags, "show 'other' directories' name only", DIR_SHOW_OTHER_DIRECTORIES), - OPT_BIT(0, "empty-directory", &dir.flags, - "list empty directories", + OPT_BIT(0, "no-empty-directory", &dir.flags, + "don't show empty directories", DIR_HIDE_EMPTY_DIRECTORIES), OPT_BOOLEAN('u', "unmerged", &show_unmerged, "show unmerged files in the output"),
Thanks for catching this. But then why not using PARSE_OPT_NONEG? That would avoid --no-no-empty-directory.
Attachments
- (unnamed) [application/pgp-signature] 197 bytes