Re: [PATCH] http: add_fill_function checks if function has been added

Hi,

On Sun, Mar 8, 2009 at 4:18 AM, Junio C Hamano [off-list ref] wrote:

Could you care to explain the following a bit better?

 - what "possible issues" you are addressing;

 - what changes in the behaviour that are not "obvious" we would be
  suffering from, if we apply this patch;

 - in what situation the performance _might_ be affected, in what way and
  to what extent.

(note: "repeatedly" here means looping over it, eg. while(condition)
fill_function(). )

Thanks for taking the time to give this clear and detailed example explanation.

However, at this point of time, I couldn't come up with a convincing
instance of where

 *a fill function is added twice or more, and as a result

 *something breaks as a result of invoking the function repeatedly

that was why I used the word "possible" as in "possible issues",
because this patch doesn't solve any existing issues (at least none
that I know of now).

Calling a fill function repeatedly won't break behaviour, because fill
functions (those that are currently defined in git) are designed to be
called repeatedly. But it's just useless to call the same fill
function repeatedly without any reason.

So should I still address the "THIS and THAT breakages"?

-- 
Cheers,
Ray Chuan