Re: [PATCH] '%S' option for pretty printing to support --source

Hi,

On Thu, 5 Mar 2009, Jeff King wrote:

On Thu, Mar 05, 2009 at 09:18:28AM +0200, Petri Hodju wrote:

quoted

+static void format_source(struct strbuf *sb, const struct commit *commit)
+{
+    if (commit->util)
+	strbuf_addstr(sb, (char *) commit->util);
+}
+

Hmm. This is the second patch in the last few weeks to use commit->util
to carry information for --pretty=format: (I am cc'ing Deskin Miller,
who wrote the first).

They cannot both work, obviously. So we need to do one of:

  - refactor the information out of commit->util to somewhere else

  - allow multiple commit->util users somehow (which I think is a
    potential performance problem -- the simplistic design is meant to
    avoid things like allocation overhead)

The common way to do this is to use struct decoration.  I was under the 
impression that --source already used that method (IIRC both --source and 
struct decoration come from Linus, the latter of which having been 
rejected when I submitted it as a struct object_hash patch, which would 
have been a better name IMHO).

Ciao,
Dscho