Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Make the 'lock file exists' error more informative

From: Matthieu Moy <hidden>
Date: 2016-06-15 22:46:19

John Tapsell [off-list ref] writes:
It looks like someone did 90% of the work, then forgot to actually use
the function
someone = me ;-).

The message is a bit inacurrate: the function is already used in two
places, I just didn't notice this one.
-	if (errno == EEXIST) {
+	if (err == EEXIST) {
Oops, right.
-			die("unable to create '%s.lock': %s", path, strerror(errno));
+			unable_to_lock_index_die(path, errno);
Actually, _this_ instance is still to be fixed in next. You probably
looked at the other one that my original message fixes.

IOW:

Acked-by: Matthieu Moy <redacted>

-- 
Matthieu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help