Re: [PATCH] git.el: Only show completions from refs/heads
From: David Kågedal <hidden>
Date: 2016-06-15 22:46:18
Alexandre Julliard [off-list ref] writes:
David Kågedal [off-list ref] writes:quoted
Signed-off-by: David Kågedal <redacted> --- Here is a version that can to both commit name lookup and branch name lookup, and with a configuration parameter that determines how to find branch names to complete on.Why do you introduce a separate function for checkouts? I don't see much need to have a different set of completions for checkout vs. cherry-pick, they both can be used with an arbitrary commit anyway.
Yes, but the typical uses differ a lot. The (overwhelmingly) typical use of checkout is to switch to another branch. The typical use of cherry-pick is to pick any commit and not treat branch heads specially. So when switching branches, I obviously want a simple way to select which branch to switch to. When cherry-picking, I would need some simple way of picking any single commit, but that's hard so making it easy to pick any named commit is probably the reasonable solution. -- David Kågedal