Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 2/2] bisect: string commands emited by "filter_skipped" together with "&&"

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:17

Christian Couder [off-list ref] writes:
quoted hunk
diff --git a/git-bisect.sh b/git-bisect.sh
index a9324b2..08e31d6 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -296,14 +296,14 @@ filter_skipped() {
 	do
...
 	done
+	echo ':'
Is there a particular reason you moved this echo ':' out of the downstream
of the pipe as I wrote in my response?

It logically belongs to the downstream in this pattern:

        producer of the list of items | {
                preparatory steps
                while read one item
                do
                        process one item
                        echo "something &&"
                done
                echo ":" ;# to conclude the && chain
        }

But you changed it to:

        preparatory step that does not concern producer

        producer of the list of items |
                while read one item
                do
                        process one item
                        echo "something &&"
                done

        echo ":"

which looks to me a lot less logical code structure.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help