Re: [PATCH 1/2] bisect: fix quoting TRIED revs when "bad" commit is also "skip"ped
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:17
Christian Couder [off-list ref] writes:
quoted hunk ↗ jump to hunk
diff --git a/git-bisect.sh b/git-bisect.sh index 85db4ba..a9324b2 100755 --- a/git-bisect.sh +++ b/git-bisect.sh@@ -288,6 +288,8 @@ filter_skipped() { return fi + VARS= FOUND= TRIED= +
Did you have any particular reason to move these out of the subshell on the downstream side of the pipe as I wrote in my response? That is where these variables matter.
quoted hunk ↗ jump to hunk
# Let's parse the output of: # "git rev-list --bisect-vars --bisect-all ..." eval "$_eval" | while read hash line@@ -309,7 +311,7 @@ filter_skipped() {
Also you seem to have lost my fix to ignore $line for "bisect_foo=value" lines where $line is always empty.