Re: [PATCH] git.el: Only show completions from refs/heads, refs/remotes and refs/tags

Alexandre Julliard [off-list ref] writes:

David Kågedal [off-list ref] writes:

quoted

Alexandre Julliard [off-list ref] writes:

quoted

David Kågedal [off-list ref] writes:

quoted

Sorry, I didn't check this properly. I thought I was fixing inside the
git-checkout function, but this is git-read-commit-name which is used
in more than one place.

But for git-checkout, I would like to see a much shorter list of named
commits, namely those that can be called "branches". I'll come up with
a better patch.

I think it's reasonable to do this for the other uses of
git-read-commit-name too, so your original patch looks OK.

Actually, I'd like to go one step further. I'm only interested in
branches, and only in branches I can commit to. So only asking for
refs/heads seems the best solution.

I think that's going too far. It's useful to be able to checkout a tag,
or to cherry-pick from a remote branch.

Cherry-pick, yes. And checkout, sometimes. My problem is that I have a
truckload of remote (svn) branches and that means I can't see the
obvious checkout candidates for all the noise.

But add "refs/remotes" and "refs/tags" to the last patch, and maybe we
have a good compromise.

-- 
David Kågedal