Thread (12 messages) flat view 12 messages, 4 authors, 2016-06-15

Re: [PATCH] Add bare repository indicator for __git_ps1

From: Ted Pavlic <hidden>
Date: 2016-06-15 22:46:16

Reverting GIT_DIR! ugliness is certainly a possibility.  As long as people
who chdir into there are the only ones who suffer from the ugliness I do
not particularly care that much, though ;-)

Will apply anyway.
I only added the "GIT_DIR!" on the advice of Junio, who suggested a 
"danger" flag. I asked for suggestions on replacement text.

Keep in mind that "BARE:master" doesn't make much sense. If you're in a 
git dir, you don't have a working directory. "BARE" alone makes sense. 
Personally, I think it makes more sense to submit a patch that changes 
"GIT_DIR!" to "BARE" in the bare case (and doesn't print any branch).

--Ted


-- 
Ted Pavlic [off-list ref]

   Please visit my ALS association page:
         http://web.alsa.org/goto/tedpavlic
   My family appreciates your support in the fight to defeat ALS.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help