Re: [PATCH B v4 1/5] git config: reorganize to use parseopt

On Sun, Feb 22, 2009 at 6:48 PM, Junio C Hamano [off-list ref] wrote:

Felipe Contreras [off-list ref] writes:

quoted

+     else if (actions == ACTION_GET_COLORBOOL) {
+             if (argc == 1)
+                     stdout_is_tty = git_config_bool("command line", argv[0]);
+             else if (argc == 0)
+                     stdout_is_tty = isatty(1);
+             return get_colorbool(argc != 0);
+     }

I see you fixed this from the last series...

Yes, argc != 1 was wrong. Now I've made sure all the tests pass.

-- 
Felipe Contreras