Re: [PATCH v4] Test fsck a bit harder

On Samstag, 21. Februar 2009, Thomas Rast wrote:

I changed the tests
to use

	test_must_fail git fsck 2>&1 | tee out

instead, which both checks the exit status and makes the tests more
verbose with -v.

This is wrong: It does not test the exist status. In a pipeline, the shell 
looks only at the exit status of the last command. You really want this as

 	test_must_fail git fsck >out 2>&1 &&

If you want to have it more verbose, add 'cat out &&'. But IMHO that is 
overengineered. If the test detects a regression in the future, it is easy to 
inspect the file out if necessary.

-- Hannes