Thread (13 messages) flat view 13 messages, 3 authors, 2016-06-15

Re: [PATCH v3 01/10] config: Codestyle cleanups.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:14

Felipe Contreras [off-list ref] writes:
Hmm, right. I was thinking on Junio and Johanness that already know
the context, so they don't need an introduction, but I forgot about
other people that might be interested in giving this a review.
Also please don't assume anything about what other people may remember
from your earlier series, after you received "this round is not ready to
be applied because of this and that" comments.  As far as the reviewer is
concerned, that's the end of the story about the entire series, until you
send a revised one.  The reviewers are not promising to remember the fine
details of the code and to help you improve the series, thinking about the
series all the time until its next round materializes by reviewing the
first round, and it is unrealistic to expect them to.  There are a lot
more patches and patch writers than there are people who review them.

The reason you are encouraged to say want was changed since the previous
series when you are sending v(n+1) patch in each patch after three-dash
lines is exactly because by default we expect reviewers remember nothing
about the previous round and jogging their memory in such a way would help
reviewing the new round.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help