Thread (6 messages) flat view 6 messages, 4 authors, 2016-06-15

Re: [PATCH v2 1/8] config: Trivial rename in preparation for parseopt.

From: Felipe Contreras <hidden>
Date: 2016-06-15 22:46:13

On Tue, Feb 17, 2009 at 2:01 PM, Johannes Schindelin
[off-list ref] wrote:
Hi,

On Tue, 17 Feb 2009, Felipe Contreras wrote:
quoted
        free(repo_config);
+       if (found == 0)
+               error("no config file found");
        return ret;
Err, you mean "return error(..)"?

But it might be not an error at all: think of "cd / && git ls-remote $URL"
without /etc/gitconfig nor $HOME/.gitconfig.
Yeah, I thought about that when doing the patch. I've removed the
error(), now it will only return -1. Almost nobody is checking the
return code anyways.

-- 
Felipe Contreras
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help