Thread (11 messages) flat view 11 messages, 2 authors, 2016-06-15

Re: [PATCH v2 4/8] config: Disallow multiple variable types.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:13

Felipe Contreras [off-list ref] writes:
+	if (HAS_MULTI_BITS(types)) {
+		error("only one type at a time.");
+		usage_with_options(builtin_config_usage, builtin_config_options);
+	}
You would be able to catch "config --bool --get-color color.diff.whitespace"
as an error by doing something similar to the "fake actions" for get-color*
as I suggested in my review on [3/8].

I did not find anything objectionable in the remainder of the series.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help