Re: [PATCH] config: Use parseopt.

On Sat, Feb 14, 2009 at 1:52 PM, Jakub Narebski [off-list ref] wrote:

Felipe Contreras [off-list ref] writes:

quoted

Reorganizing the code to use parseopt as suggested by Johannes
Schindelin.

[...]

quoted

-static const char git_config_set_usage[] =
-"git config [ --global | --system | [ -f | --file ] config-file ] [ --bool | --int | --bool-or-int ] [ -z | --null ] [--get | --get-all | --get-regexp | --replace-all | --add | --unset | --unset-all] name [value [value_regex]] | --rename-section old_name new_name | --remove-section name | --list | --get-color var [default] | --get-colorbool name [stdout-is-tty] | --edit | -e ]";
+static const char *const builtin_config_usage[] = {
+     "git config [options]",
+     NULL
+};

Just asking: why this change?

So it's easier to understand and maintain?

quoted

+     OPT_BOOLEAN('z', "null", &end_null, "end values with null character"),

Terminate and NUL.

Ok. Junio already suggested that.

-- 
Felipe Contreras