Thread (25 messages) flat view 25 messages, 4 authors, 2016-06-15

Re: [PATCH 4/4] builtin-remote: add set-head verb

From: Jay Soffian <hidden>
Date: 2016-06-15 22:46:10

Possibly related (same subject, not in this thread)

On Fri, Feb 13, 2009 at 9:18 PM, Jeff King [off-list ref] wrote:
Test #8 is just a matter of updating output. But #18 is explicitly about
checking that "remote show" does not show symbolic refs. But Jay's patch
is about explicitly showing symbolic refs (just doing so as a ref-name
instead of a sha1):

 * FAIL 18: "remote show" does not show symbolic refs
               git clone one three &&
               (cd three &&
                git remote show origin > output &&
                ! grep HEAD < output &&
                ! grep -i stale < output)

I guess we could tighten the grep to

 ! egrep "HEAD: [0-9a-f]{40}" < output

but it may just make sense to get rid of the test; the exact output is
already covered by test #8. Squashable patch is below.
Thank you Jeff. I swear I ran t5505-remote.sh successfully but
obviously I am misremembering.

j.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help