Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 2/3] completion: Change "if [...]" to "if test ..." to match git convention

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:09

Ted Pavlic [off-list ref] writes:
In the single case of:

    if [...] || [...]

changed to:

    if test ... || test ...
In [0/3] you talked about "git convention", but please match the local
convention, especially inside contrib/ area.  That is, consistency of the
style within the same file (and files in vicinity), is more important.
Also changed:

    if test ...
    then

to:

    if test ...; then
The prevailing style in bash completion script is to write "then" on the
same line as "if", so I think this is a good example of matching the local
convention (if you are trying to match "git convention", "then" is written
on the same column as "if" on a line by itself for readability, so this
change is going backwards).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help