Re: [PATCH] git-filter-branch: Add more error-handling

Johannes Sixt schrieb:

quoted

@@ -483,7 +486,7 @@ test -z "$ORIG_GIT_INDEX_FILE" || {
 }
 
 if [ "$(is_bare_repository)" = false ]; then
-	git read-tree -u -m HEAD
+	git read-tree -u -m HEAD || die "Unable to checkout rewritten tree"

Here you shouldn't die.

I take this back. I was distracted by the 'exit $ret' that is visible in
the context:

quoted

 fi
 
 exit $ret

But this exit statement is pointless: ret is initialized to zero and never
changed.

-- Hannes