Re: [PATCH] fast-export: ensure we traverse commits in topological order

Hi,

On Wed, 11 Feb 2009, Jeff King wrote:

On Wed, Feb 11, 2009 at 10:48:18AM +0000, Mike Ralphson wrote:

quoted

quoted

On Tue, 10 Feb 2009, newren@gmail.com wrote:
fast-export will only list as parents those commits which have already
been traversed (making it appear as if merges have been squashed if not
all parents have been traversed).  To avoid this silent squashing of
merge commits, we request commits in topological order.

Any comparative timings? We don't need to rename this to 'git
reasonably-speedy-export'? 8-)

Hmm.

In git.git:

  $ time git fast-export --all --signed-tags=strip >/dev/null
  real    1m6.013s
  user    1m3.840s
  sys     0m2.140s

  $ time git fast-export --all --signed-tags=strip --topo-order >/dev/null
  real    0m49.018s
  user    0m47.987s
  sys     0m0.888s

I certainly didn't expect it to be _faster_.  More efficient use of the
delta cache, maybe?

Or a warm against a cold cache?

Hides,
Dscho