Re: [PATCH] Fix file mark handling and sort side-effects in git.el

Brent Goodrick [off-list ref] writes:

The `sort' Elisp function works destructively, causing anomalies where
operations on multiple files would be performed on one file.  This
checkin works around that by doing a deep copy with `append'.

This shouldn't be necessary, it's OK for git-status-update-files to
destroy the list. If there are callers that want the list to be
preserved they should save it themselves.

Also, git-add-file needed to pass 'modified to git-marked-files-state,
as otherwise, files that are modified but not yet in the index would
not show up in the git-marked-files-state return value, which would
then cause a prompt for file to show up when the files are clearly
marked in the status buffer.

Not sure what you mean here, it should not be possible for a file to be
in modified state but not in the index. If you mean using git-add-file
to do an update-index on an already tracked file, that's not what it's
meant to do.

-- 
Alexandre Julliard
julliard@winehq.org