Re: gc considered dangerous

On Sun, Feb 08, 2009 at 12:00:57PM -0800, Junio C Hamano wrote:

Johannes Schindelin [off-list ref] writes:

quoted

My preliminary guess is that this code in pack-write.c needs to use the 
lock file paradigm:

        if (!index_name) {
		[...]
        } else {
                unlink(index_name);
                fd = open(index_name, O_CREAT|O_EXCL|O_WRONLY, 0600);
        }

Whoa.  That particular code has been (and is still) correct.

Don't both unlink and open fail in the case the index file is locked in
Windows ?

Mike