Re: [PATCH] Support various HTTP authentication methods

Moriyoshi Koizumi schrieb:

Johannes Sixt wrote:

quoted

Moriyoshi Koizumi schrieb:

quoted

@@ -210,6 +272,20 @@ static CURL* get_curl_handle(void)
 	if (curl_http_proxy)
 		curl_easy_setopt(result, CURLOPT_PROXY, curl_http_proxy);

CURLOPT_PROXY is set here...

As I wrote in the previous post, this part was from the original.

quoted

quoted

 
+	if (curl_http_auth) {
+		long n = get_curl_auth_bitmask(curl_http_auth);
+		curl_easy_setopt(result, CURLOPT_HTTPAUTH, n);
+	}

quoted

... and here again. Is that necessary?

What part do you mean by that?

Oops, sorry, I cut too much from your patch:

+	if (curl_http_auth) {
+		long n = get_curl_auth_bitmask(curl_http_auth);
+		curl_easy_setopt(result, CURLOPT_HTTPAUTH, n);
+	}
+
+	if (curl_http_proxy) {
+		curl_easy_setopt(result, CURLOPT_PROXY, curl_http_proxy);

Here you set CURLOPT_PROXY again.

-- Hannes