Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] http-push: refactor request url creation

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:02

Johannes Schindelin [off-list ref] writes:
quoted
curl strdup's it, so this is safe.
I might have mentioned that things like this _need_ to go into the commit 
message.
Yeah, and let's not forget advice from Daniel Stenberg.

    I'm not sure what the oldest possibly libcurl version git can deal
    with, but here's a related quote from the curl_easy_setopt man page:

           NOTE: before 7.17.0 strings were  not  copied.  Instead  the  user  was
           forced keep them available until libcurl no longer needed them.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help