Thread (6 messages) flat view 6 messages, 3 authors, 2016-06-15

Re: [PATCH] git-svn: add --ignore-paths option for fetching

From: Eric Wong <hidden>
Date: 2016-06-15 22:46:01

public_vi [off-list ref] wrote:
Eric Wong wrote:
quoted
Thomas Rast [off-list ref] wrote:
  

Also, indentation is always done with tabs in git-svn (and the vast
majority of git as well).

  
Whitespace is invisible for me now, I only checked according to  
Documentation/SubmittingPatches about extra lines adds or removes caused  
just by whitespace difference.
quoted

Vitaly: thank you for the patch.  Can you also provide a testcase to
ensure this functionality doesn't break during refactorings?  Thanks.

  
Already done it with testcase. There are two new packs of patches sent  
to git@vger.kernel.org, the first is outdated too, the second is current.
(I don't yet completely know how things should be done).
Thanks Vitaly, acked and pushed out with minor fixes to
git://git.bogomips.org/git-svn.git

git-svn: Add test for --ignore-paths parameter
    [ew: replaced 'echo -e' with printf so it works on POSIX shells]
    [ew: added Vitaly to copyright even though it's based on my test]

git-svn: documented --ignore-paths
    [ew: trailing whitespace removed]

git-svn: add --ignore-paths option for fetching
    [ew: replaced 4-space indent with tabs]
    [ew: prefixed $ignore_regex with an underscore to be consistent
         with other globals in git-svn]
    [ew: rearranged functions to minimize diff and removed prototype
         usage to be consistent with the rest of git-svn (and other
         Perl code in git (and they're ugly to me)]

-- 
Eric Wong
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help