Re: [PATCH v1 3/3] git-gui hooks for new config variable "diff.primer"

Hi,

On Sun, 25 Jan 2009, Keith Cascio wrote:

git-gui hooks for new config variable "diff.primer".
Add three checkboxes to both sides of
options panel (local/global).
Add a sub-menu named "White Space" to
diff-panel right-click context menu, with
three checkboxes.

Rather than storing the information about how to call "git diff" as 
diff.primer, why don't you store that information in a config variable 
gui.whiteSpaceMode and teach "git gui" to call "git diff" accordingly?

That would have the further advantage of not breaking other people's 
setups...

 git-gui/git-gui.sh     |   51 ++++++++++++++++++++++++++++++++++++++++++
 git-gui/lib/option.tcl |   57 +++++++++++++++++++++++++++++++++++++++++++----

Please submit git-gui patches without the git-gui prefix, as it makes it 
harder on the maintainer of git-gui, Shawn (who you did not Cc: BTW).

Ciao,
Dscho