Re: [PATCH] Change octal literals to be XEmacs friendly

malc [off-list ref] writes:

On Fri, 23 Jan 2009, Junio C Hamano wrote:

quoted

malc@pulsesoft.com writes:

quoted

case uses eql and (eql ?\001 1) evaluates to nil under XEmacs
(probably because some internal type of ?\001 is char)

And I presume the new way to spell is compatible with non XEmacs emacs?
It may be obvious to you, but please spell it out.  Parenthesized
"probably" does not help building the confidence in the patch either.

Fair enough.

XEmacs:
(type-of ?\1) yields character

FSF Emacs:
(type-of ?\1) yields integer

No use explaining that to me _here_.  Please use that knowledge to write a
better description in an updated commit log message when sending your v2
patch.

quoted

quoted

Signed-off-by: Vassili Karpov <redacted>

How are the (nameless) author of the patch malc@pulsesoft.com and Vassili
Karpov, the person who signed off, related?

Both are my e-mail address used in ~/.gitconfig and ~/.emacs (and used
by GNUS which was used to post the message via gmane's nntp interface)
respectively.

Assuming that you would want to be known as Vassili, please have that name
on From: line of the message -- the patch acceptance tool takes the author
name from there.

If you can't for whatever reason use the name on From: line of the e-mail
message, you can begin the body of the message with

	From: Vassili Karpov [off-list ref]

(without indentation) and a blank line.  This trick can also be used when
you are forwarding a patch somebody else wrote.