Re: [RFC/PATCH v3 2/3] sha1_file: prepare for adding alternates on demand

On Fri, Jan 23, 2009 at 00:43, Johannes Schindelin
[off-list ref] wrote:

On Thu, 22 Jan 2009, Lars Hjemli wrote:

quoted

+             if (!quiet)
+                     error("object directory %s does not exist; "
+                           "check .git/objects/info/alternates.",
+                           ent->base);

FWIW my concern is not at all addressed.  A future user of add_alt_odb()
(and possibly your users in rare cases, too) can trigger the error that
suggests looking into the alternates.  Leaving the human user puzzled.

Is it the phrasing of the error message that concerns you (when
invoked from add_alt_odb())?

If so, would something like this be ok/better?

quoted

+             if (!quiet)
+                     error("Alternate object directory %s does not exist ",
+                           ent->base);

--
larsh