Re: valgrind patches, was Re: What's cooking in git.git (Jan 2009, #04; Mon, 19)

Hi,

On Wed, 21 Jan 2009, Jeff King wrote:

On Wed, Jan 21, 2009 at 04:42:22PM -0800, Junio C Hamano wrote:

quoted

Independent from the above, I suspect that some of the existing tests 
cannot run in parallel; I haven't really looked at any of them, but a 
server-ish tests to open a local port and test interaction with client 
obviously need to either use different ports or serialize.  Perhaps we 
need a way to mark some tests that cannot be run in parallel even 
under "make -j"?

I think the only culprits are http-push and a few SVN tests. The 
http-push test starts a server on a specific port, but because it is the 
only script which uses that port, it is fine. It looks like a few 
different SVN tests start an httpd server (9115, 9118, and 9120), which 
could potentially interact badly. I've never had a problem running with 
"-j4", but I don't have svn installed, so I always end up skipping those 
tests.

It looks like both the http-push and svn tests are set up to take an 
arbitrary port as input. Perhaps the simplest thing would be for each of 
the svn tests to pick a different port so that they can be run 
simultaneously.

I _suspect_ that the svn tests already use different ports (or can work 
with the same httpd), as I have subversion installed and run with -j50 
regularly.

Ciao,
Dscho