Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH (resend) 2/2] difftool: put the cursor on the editable file for Vim

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:59

Ok, I see you updated from r to l.

Please do not mark such "an earlier one had a thinko, and here is a
corrected patch" as "resend".  It is confusing, because "resend" usually
means "I sent this earlier but somehow it did not reach the list, so here
is another copy verbatim."

Instead, please add a sentence or two after "---" lines to explain the
situation, like...

    You only need to edit worktree files when comparing against
    the worktree.  Put the cursor automatically into its window for
    vimdiff and gvimdiff to avoid doing <C-w>r every time.

    Signed-off-by: David Aguilar [off-list ref]
    ---

    Markus pointed out that 'l' is not left (it is right as in vi key
    bindings).

     contrib/difftool/git-difftool-helper |    8 ++++++--
     1 files changed, 6 insertions(+), 2 deletions(-)

and say "[PATCH 2/2 (corrected)]" so that I can easily tell which one was
a dud and which one I should take.

This time it wasn't confusing because the exchange between Markus and you
were the only unread messages before your three patches in my mailbox, but
you are not always that lucky.

Will take your original 1/2 and this one.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help