Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: fatal: git grep: cannot generate relative filenames containing '..'

From: Hannu Koivisto <hidden>
Date: 2016-06-15 22:45:58

Junio C Hamano [off-list ref] writes:
"George Spelvin" [off-list ref] writes:
quoted
Could someone fix this some day?
As far as I know you are the first to ask for this, so perhaps people never
considered this was something to "fix"....
I for one have faced that problem and considered it something that
would be nice to have fixed.  Then again, I consider the default
behaviour (when you pass no path) a bigger usability problem.
quoted
While you're at it, an option to search the entire git tree rather than
the current subdirectory would also be useful.  I was thinking about
a flag like -r (for "root"),...
It turns out that this "entire git tree" is practically my only use
case when using normal (find and) grep and when I first tried git
grep, I actually expected it to do just that with no path specified.

Why?  Because of the way at least git diff and git log work.  I
thought that just like with them, "git grep foo" would search the
entire git tree and I would have to say "git grep foo ." to limit to
the current directory and its subdirectories.  git-grep(1)'s "Look
for specified patterns in the working tree files..." at least
didn't seem to disagree with my expectation so I was a bit puzzled.

So I'd rather see git grep behave in a way consistent with git log
and git diff (I realize that would change current behaviour instead
of extending it).

-- 
Hannu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help