Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [RFC PATCH 4/3] Add example git-vcs-p4

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:56

Daniel Barkalow [off-list ref] writes:
quoted
vcs-p4.c:504: warning: ISO C90 forbids mixed declarations and code
make: *** [vcs-p4.o] Error 1
I haven't been over the 4/3 stuff for coding style yet. But how do you get 
these warnings?
I thought I have mentioned this already, but...

I compile with (at least) these:

    -Wno-pointer-to-int-cast
    -Wold-style-definition
    -Wdeclaration-after-statement

explicitly specified.

I also run kernel's checkpatch.pl script (but ignoring "more than 80-col
is too long" rule) from time to time.

I consider these are good ways to check style-discipline.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help